Change in osmo-bts[master]: measurement: remove over-defensive checks in is_meas_complete()

fixeria gerrit-no-reply at lists.osmocom.org
Fri Jun 4 21:21:25 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24527 )

Change subject: measurement: remove over-defensive checks in is_meas_complete()
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> then maybe tat least the pchan check is something for an OSMO_ASSERT()?

We do not assert the result of ts_pchan() in other places, and I don't see why should we do it here...


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24527
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6d20d7cba49cc8b6d1dc2192598ca372b7d2c5bf
Gerrit-Change-Number: 24527
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Jun 2021 21:21:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210604/c677eaa5/attachment.htm>


More information about the gerrit-log mailing list