Change in osmocom-bb[master]: trx_toolkit: add primary/shadow indicator for TRXDv2 PDUs

laforge gerrit-no-reply at lists.osmocom.org
Fri Jun 4 20:07:34 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/24509 )

Change subject: trx_toolkit: add primary/shadow indicator for TRXDv2 PDUs
......................................................................

trx_toolkit: add primary/shadow indicator for TRXDv2 PDUs

Change-Id: I0a3ad4f0bda56b93e0ab8bf82b6b3758831edf60
Related: SYS#4895, OS#4941, OS#4006
---
M src/target/trx_toolkit/trxd_proto.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/target/trx_toolkit/trxd_proto.py b/src/target/trx_toolkit/trxd_proto.py
index 74a3124..21fe31e 100644
--- a/src/target/trx_toolkit/trxd_proto.py
+++ b/src/target/trx_toolkit/trxd_proto.py
@@ -40,7 +40,8 @@
 
 		if ver >= 2: # TRXDv2 and higher
 			f.append(codec.BitField('batch', bl=1))
-			f.append(codec.BitField.Spare(bl=1))
+			f.append(codec.BitField('shadow', bl=1) if batched
+			    else codec.BitField.Spare(bl=1))
 			f.append(codec.BitField('trxn', bl=6))
 
 		codec.BitFieldSet.__init__(self, set=tuple(f))

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/24509
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I0a3ad4f0bda56b93e0ab8bf82b6b3758831edf60
Gerrit-Change-Number: 24509
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210604/d5daafc6/attachment.htm>


More information about the gerrit-log mailing list