Change in osmo-bts[master]: [VAMOS] conf_lchans_as_pchan(): improve readability

laforge gerrit-no-reply at lists.osmocom.org
Fri Jun 4 20:03:43 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24485 )

Change subject: [VAMOS] conf_lchans_as_pchan(): improve readability
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/24485/1/src/common/oml.c 
File src/common/oml.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24485/1/src/common/oml.c@824 
PS1, Line 824: 	} while(0)
> I find this macro a bit confusing. I don't think that this part is performance critical or anything. […]
I agree. Not sure why there's a need to do this in a MACRO.  All the input data thpes are static, so it should be possible to do this in a [inline] function.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24485
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1c5a033e89d9ca5fb01ebe9ffb521fd67d159bee
Gerrit-Change-Number: 24485
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: dexter <pmaier at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 04 Jun 2021 20:03:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210604/fdd3bbf4/attachment.htm>


More information about the gerrit-log mailing list