Change in osmo-ttcn3-hacks[master]: library/PCUIF_Types: fix wrong parameter type in ts_PCUIF_DATA_IND

laforge gerrit-no-reply at lists.osmocom.org
Fri Jun 4 19:57:17 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24415 )

Change subject: library/PCUIF_Types: fix wrong parameter type in ts_PCUIF_DATA_IND
......................................................................

library/PCUIF_Types: fix wrong parameter type in ts_PCUIF_DATA_IND

The 'lqual_cb' represents the link quality in centiBels, which
can be negative.  Use 'int16_t' instead of 'uint16_t'.

Change-Id: I038eec22928d831ddbc0a2704830d5e2eab2cb6b
---
M library/PCUIF_Types.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/library/PCUIF_Types.ttcn b/library/PCUIF_Types.ttcn
index b259cfc..9d6b023 100644
--- a/library/PCUIF_Types.ttcn
+++ b/library/PCUIF_Types.ttcn
@@ -438,7 +438,7 @@
 						 template (value) int8_t rssi := -80,
 						 template (value) uint16_t ber10k := 0,
 						 template (value) int16_t ta_offs_qbits := 0,
-						 template (value) uint16_t lqual_cb := 10) := {
+						 template (value) int16_t lqual_cb := 10) := {
 	msg_type := PCU_IF_MSG_DATA_IND,
 	bts_nr := bts_nr,
 	spare := '0000'O,

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24415
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I038eec22928d831ddbc0a2704830d5e2eab2cb6b
Gerrit-Change-Number: 24415
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210604/d74fad4c/attachment.htm>


More information about the gerrit-log mailing list