Change in libosmocore[master]: osmo_select_shutdown: allow finishing pending writes on sigterm

neels gerrit-no-reply at lists.osmocom.org
Fri Jun 4 14:40:35 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24544 )

Change subject: osmo_select_shutdown: allow finishing pending writes on sigterm
......................................................................


Patch Set 1:

(1 comment)

Here is a proposal, an idea to get rid of the unconditional sleep() we have in at least osmo-bsc.
I just hacked it up and it seems to work, any reasons why this could be a bad idea?

https://gerrit.osmocom.org/c/libosmocore/+/24544/1/src/select.c 
File src/select.c:

https://gerrit.osmocom.org/c/libosmocore/+/24544/1/src/select.c@103 
PS1, Line 103: bool osmo_select_shutdown_done = false;
maybe these should rather be function calls, to be able to extend the functionality in the future?

  void osmo_select_shutdown_request() { _osmo_select_shutdown = true; };
  bool osmo_select_shutdown_requested() { return _osmo_select_shutdown; };
  bool osmo_select_shutdown_done() { return _osmo_select_shutdown_done; };

I'm not sure whether that is helping or just bloat. what do you think?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24544
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib94d4316924103459577087c2214188679db2227
Gerrit-Change-Number: 24544
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Fri, 04 Jun 2021 14:40:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210604/14c8fc79/attachment.htm>


More information about the gerrit-log mailing list