Change in osmo-bsc[master]: bts_uptime(): do not spam logs with 'OML link uptime unavailable'

fixeria gerrit-no-reply at lists.osmocom.org
Fri Jun 4 01:34:03 UTC 2021


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24541 )


Change subject: bts_uptime(): do not spam logs with 'OML link uptime unavailable'
......................................................................

bts_uptime(): do not spam logs with 'OML link uptime unavailable'

This message periodically appears in the logs with subsys=DNM and
level=INFO for every disconnected BTS.  I find this message useless
and even annoying, so I propose to remove it in this patch.

Change-Id: I7e2498cc61d311ca08585b2f1c49de021b17a5a1
---
M src/osmo-bsc/bts.c
1 file changed, 1 insertion(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/41/24541/1

diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c
index 857ddd2..0c699c3 100644
--- a/src/osmo-bsc/bts.c
+++ b/src/osmo-bsc/bts.c
@@ -565,10 +565,8 @@
 {
 	struct timespec tp;
 
-	if (!bts->uptime || !bts->oml_link) {
-		LOGP(DNM, LOGL_INFO, "BTS %u OML link uptime unavailable\n", bts->nr);
+	if (!bts->uptime || !bts->oml_link)
 		return 0;
-	}
 
 	if (osmo_clock_gettime(CLOCK_MONOTONIC, &tp) != 0) {
 		LOGP(DNM, LOGL_ERROR, "BTS %u uptime computation failure: %s\n", bts->nr, strerror(errno));

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24541
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I7e2498cc61d311ca08585b2f1c49de021b17a5a1
Gerrit-Change-Number: 24541
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210604/d25f1fd0/attachment.htm>


More information about the gerrit-log mailing list