Change in osmo-asf4-dfu[master]: usb serial number descriptor

laforge gerrit-no-reply at lists.osmocom.org
Thu Jun 3 18:33:20 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/17024 )

Change subject: usb serial number descriptor
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/17024/2/usb_start.c 
File usb_start.c:

https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/17024/2/usb_start.c@121 
PS2, Line 121: SYSMOOCTSIM
> I wanted to have something that works with the current octsim, the string index depends on the actua […]
everyone starts with something that works first, and then cleans it up or generalizes it, if possible.

The string descriptor index is configurable AFAICT (CONF_USB_DFUD_ISERIALNUM). Am I missing something?

sharing code between bootloader and application is completely orthogonal and not reaally on-topic here, IMHO.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/17024
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-Change-Id: I4a23682cee0849c788e5f6c611df4ed1f1cac3da
Gerrit-Change-Number: 17024
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: roh <jsteiger at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 03 Jun 2021 18:33:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild at sysmocom.de>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210603/9de19332/attachment.htm>


More information about the gerrit-log mailing list