Change in osmo-ttcn3-hacks[master]: add bsc/BSC_Tests_VAMOS.ttcn

neels gerrit-no-reply at lists.osmocom.org
Thu Jun 3 12:22:31 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411 )

Change subject: add bsc/BSC_Tests_VAMOS.ttcn
......................................................................


Patch Set 13:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411/10/bsc/BSC_Tests_VAMOS.ttcn 
File bsc/BSC_Tests_VAMOS.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411/10/bsc/BSC_Tests_VAMOS.ttcn@89 
PS10, Line 89: 	var integer subslot;
> I would set it to 0, otherwise you may return an unbound value.
if a test calls this function on an unimplemented channel type, we should rather get an error message, so added that instead.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2c504099163a30ea102cbd26d3615ca2e5ce1e64
Gerrit-Change-Number: 24411
Gerrit-PatchSet: 13
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 03 Jun 2021 12:22:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210603/9d69fd11/attachment.htm>


More information about the gerrit-log mailing list