Change in libosmo-abis[master]: ipa: add optional connect timeout to ipa_client_conn_open

pespin gerrit-no-reply at lists.osmocom.org
Thu Jun 3 09:54:18 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/24514 )

Change subject: ipa: add optional connect timeout to ipa_client_conn_open
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/libosmo-abis/+/24514/1/src/input/ipa.c 
File src/input/ipa.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/24514/1/src/input/ipa.c@233 
PS1, Line 233: 
> ws
He's just adding a new line here because he's adding new blocks to the function, so that different steps are more readable. It's fine adding this new line as part of the change.


https://gerrit.osmocom.org/c/libosmo-abis/+/24514/1/src/input/ipa.c@247 
PS1, Line 247: 		ret = osmo_sock_wait(link->ofd->fd, timeout_msec);
So this is the use case you were saying it's fine blocking? Inside a library function? Doesn't look correct to me at first glance.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/24514
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I7bc4345876e3c20266985270d0ddfa770437a053
Gerrit-Change-Number: 24514
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 03 Jun 2021 09:54:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210603/4b426f16/attachment.htm>


More information about the gerrit-log mailing list