Change in osmo-mgw[master]: mgcp_client: do not crash when lco/sdp can not be generated

pespin gerrit-no-reply at lists.osmocom.org
Thu Jun 3 09:33:23 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24182 )

Change subject: mgcp_client: do not crash when lco/sdp can not be generated
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/osmo-mgw/+/24182/2/src/libosmo-mgcp-client/mgcp_client.c 
File src/libosmo-mgcp-client/mgcp_client.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/24182/2/src/libosmo-mgcp-client/mgcp_client.c@1236 
PS2, Line 1236: 			} else
no need for else here, there's early return. Moreover, you are using {} in the if clause but no in the else one.


https://gerrit.osmocom.org/c/osmo-mgw/+/24182/2/src/libosmo-mgcp-client/mgcp_client.c@1353 
PS2, Line 1353: 		else
same here, no need for else.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24182
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ibb788343e0bec9c0eaf33e6e4727d4d36c100017
Gerrit-Change-Number: 24182
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 03 Jun 2021 09:33:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210603/f127ddca/attachment.htm>


More information about the gerrit-log mailing list