Change in libosmocore[master]: gsm_08_58.h: add mask for Osmocom specific VAMOS C-bits

fixeria gerrit-no-reply at lists.osmocom.org
Thu Jun 3 03:33:11 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24507 )

Change subject: gsm_08_58.h: add mask for Osmocom specific VAMOS C-bits
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/24507/2/include/osmocom/gsm/protocol/gsm_08_58.h 
File include/osmocom/gsm/protocol/gsm_08_58.h:

https://gerrit.osmocom.org/c/libosmocore/+/24507/2/include/osmocom/gsm/protocol/gsm_08_58.h@465 
PS2, Line 465: #define RSL_CHAN_OSMO_VAMOS_MASK	0xe0	/* VAMOS TCH/{F,H} */
> this mask also includes 0b11100xxx, but we only use 0b11101xxx to 0b11111xxx for VAMOS.

You're right, but I don't think it's really that critical.

>  #define RSL_CHAN_IS_OSMO_VAMOS(chan_nr) ((chan_nr) >= 0xe8)

Actually, in osmo-bts I don't even use this mask to check whether chan_nr is VAMOS. In most cases I know this from the internal structures. What I need is a quick and convenient way to set or unset the 3 MSB bits, and this approach works best.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24507
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia0bd8695a3f12331b696fe69117189cdd48b584d
Gerrit-Change-Number: 24507
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 03 Jun 2021 03:33:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210603/34fc6622/attachment.htm>


More information about the gerrit-log mailing list