Change in osmo-ttcn3-hacks[master]: MGCP_Test: avoid crash in latest (TC_one_crcx_loopback_rtp_implicit)

dexter gerrit-no-reply at lists.osmocom.org
Wed Jun 2 18:54:26 UTC 2021


dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24392 )

Change subject: MGCP_Test: avoid crash in latest (TC_one_crcx_loopback_rtp_implicit)
......................................................................

MGCP_Test: avoid crash in latest (TC_one_crcx_loopback_rtp_implicit)

The testcase TC_one_crcx_loopback_rtp_implicit triggers a bug in older
osmo-mgw version that eventually leads into a crash of osmo-mgw. This
also means that all tests after TC_one_crcx_loopback_rtp_implicit will
also fail. Lets move TC_one_crcx_loopback_rtp_implicit to the end of the
control section to postpone the crash to the very end of the testrun.

Change-Id: I25abf30f8c49e580c46e7a61e887bd0add9a4cd4
Related: OS#5123
---
M mgw/MGCP_Test.ttcn
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  dexter: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn
index c1e263a..307f0a8 100644
--- a/mgw/MGCP_Test.ttcn
+++ b/mgw/MGCP_Test.ttcn
@@ -2445,7 +2445,6 @@
 		execute(TC_one_crcx_receive_only_rtp());
 		execute(TC_one_crcx_loopback_rtp());
 		execute(TC_one_crcx_loopback_rtp_ipv6());
-		execute(TC_one_crcx_loopback_rtp_implicit());
 		execute(TC_two_crcx_and_rtp());
 		execute(TC_two_crcx_and_rtp_bidir());
 		execute(TC_two_crcx_diff_pt_and_rtp());
@@ -2474,5 +2473,11 @@
 		execute(TC_two_crcx_mdcx_and_rtp_osmux_ipv6());
 		execute(TC_two_crcx_mdcx_and_rtp_osmux_ipv4_ipv6());
 		execute(TC_two_crcx_mdcx_and_rtp_osmux_ipv6_ipv4());
+
+		/* Note: This testcase will trigger an OSMO_ASSERT() bug in
+		 * older versions of osmo-mgw. This eventually leads into
+		 * a failure of all subsequent testcases, so it is important
+		 * not to add new testcaes after this one. */
+		execute(TC_one_crcx_loopback_rtp_implicit());
 	}
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24392
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I25abf30f8c49e580c46e7a61e887bd0add9a4cd4
Gerrit-Change-Number: 24392
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210602/79f5e177/attachment.htm>


More information about the gerrit-log mailing list