Change in libosmocore[master]: socket: add function to wait until a socket becomes writeable

dexter gerrit-no-reply at lists.osmocom.org
Tue Jun 1 21:02:36 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24435 )

Change subject: socket: add function to wait until a socket becomes writeable
......................................................................


Patch Set 2:

> Patch Set 1: Code-Review-2
> 
> This still makes no sense in the context of osmocom apps with a mainloop. While waiting in that select loop you are basically blocking any other events to be parsed by the main loop.
> You need to integrate this in the osmocom mainloop.

The intended use of the function is not from inside the mainloop. I have added a note in the API documentation to make users aware of the blocking.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24435
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1c68185120fa2a6c9b6cb8aa2a25232a44ff5508
Gerrit-Change-Number: 24435
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 01 Jun 2021 21:02:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210601/0e5e9ae7/attachment.htm>


More information about the gerrit-log mailing list