Change in osmo-bsc[master]: implement Channel Mode Modify to VAMOS mode

fixeria gerrit-no-reply at lists.osmocom.org
Tue Jun 1 17:21:27 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24374 )

Change subject: implement Channel Mode Modify to VAMOS mode
......................................................................


Patch Set 13:

(4 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/24374/10/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24374/10/src/osmo-bsc/bsc_vty.c@2174 
PS10, Line 2174: modify lchan
> The "handover1 power budget interval <1-99>" and the like are annoying early mistakes from a long ti […]
Agree with Harald here.


https://gerrit.osmocom.org/c/osmo-bsc/+/24374/10/src/osmo-bsc/bsc_vty.c@2193 
PS10, Line 2193: 		vty_out(vty, "Invalid sub-slot number for this timeslot type%s", VTY_NEWLINE);
Missing %% prefix.


https://gerrit.osmocom.org/c/osmo-bsc/+/24374/10/src/osmo-bsc/bsc_vty.c@2198 
PS10, Line 2198: 		vty_out(vty, "BTS does not support VAMOS%s", VTY_NEWLINE);
Missing %% prefix.


https://gerrit.osmocom.org/c/osmo-bsc/+/24374/10/src/osmo-bsc/gsm_04_08_rr.c 
File src/osmo-bsc/gsm_04_08_rr.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24374/10/src/osmo-bsc/gsm_04_08_rr.c@714 
PS10, Line 714: 0x6d
Do we have a macro for this in libosmocore?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24374
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ibf53f4797d7491b17a33946fd7d920f038362b4c
Gerrit-Change-Number: 24374
Gerrit-PatchSet: 13
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Tue, 01 Jun 2021 17:21:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210601/b72ce2c3/attachment.htm>


More information about the gerrit-log mailing list