Change in libosmocore[master]: gsm_08_58.h: add Osmocom specific Bm/Lm CBITs for VAMOS

fixeria gerrit-no-reply at lists.osmocom.org
Tue Jun 1 15:02:02 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24420 )

Change subject: gsm_08_58.h: add Osmocom specific Bm/Lm CBITs for VAMOS
......................................................................


Patch Set 1:

Hi Harald,

> When Vadim mentioned it during the last weekly review call, I was quite surprised this was merged quickly, without a more comprehensive discussion around it.

I should have marked this patch as WIP.

> Have you done a careful review that those bit combinations really are not used anywhere else yet?
> Are we seure they don't clash e.g. with how Ericsson uses the Cbits?

I would love to, but is this information publicly available anywhere?
If there is a clash, we can still add more #defines with the same values.

> So on the BSC side there must not be any common code that makes assumptions that those osmocom-specific cbits are unversally applicable over all BTS types.

Indeed, the idea is to use these C-bits iff we're talking to osmo-bts *and* it reports BTS_FEAT_VAMOS as supported. I know that ABIS_RSL_CHAN_NR_CBITS_OSMO_PDCH is also used by Ericsson, but we also have ABIS_RSL_CHAN_NR_CBITS_OSMO_{CBCH4,CBCH8}, and both look quite Osmocom-specific.

> Furthermore, even if the above is all fine, at the same time of merging this patch I would have expected a comprehensive related update to our Abis manual where all osmocom extensions to RSL and OML are documented (https://ftp.osmocom.org/docs/latest/osmobts-abis.pdf)

Please see: https://gerrit.osmocom.org/c/osmo-bts/+/24492.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24420
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If33c1695922d110c0d2c60d5c0136caf2587194e
Gerrit-Change-Number: 24420
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 01 Jun 2021 15:02:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210601/616bdf8d/attachment.htm>


More information about the gerrit-log mailing list