Change in osmo-bsc[master]: implement Channel Mode Modify to VAMOS mode

laforge gerrit-no-reply at lists.osmocom.org
Tue Jun 1 13:53:44 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24374 )

Change subject: implement Channel Mode Modify to VAMOS mode
......................................................................


Patch Set 12: Code-Review-1

(1 comment)

I really do think cosnistency in the VTY is important and I often blame myself for not having caught something at code review which is now quite inconsistenc in the VTY.  Let's make sure we get this right before submission.

https://gerrit.osmocom.org/c/osmo-bsc/+/24374/10/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24374/10/src/osmo-bsc/bsc_vty.c@2174 
PS10, Line 2174: modify lchan
> multiple words: then what about "handover1 power budget interval <1-99>"? ;) […]
The "handover1 power budget interval <1-99>" and the like are annoying early mistakes from a long time ago when at least I did not yet understand fully the nature of VTY (or its father-in-kind of Cisco command line interfaces).  These days, whenever I see something like that, I find it almost embarrassing that we let this past code review in the first place.

I also find the ovrall lack of consistency a serious problem.  It's not about everyone putting their own style in somewhere.  The user expects consistency.

The more I thik about this, the more it should be 

"bts <0-255> trx <0-255> timeslot <0-7> sub-slot <0-7> vamos modify-lchan" or the like.  The object is specified first and then the action. This way you first specify the TRX/TS/sub-slot/... in a unique way (you iterate the tree of the data structure) and then you get a choice of actions you can do with that specific object.

I don't really care whether the trx / timeslot verbs are explicitly spelled or not.  However, as that is what we have in place for now, new commands should follow it.  And in the worst case we could always add a second 

"lchan <0-255> <0-255> <0-7> <0-1>" entry path which then accepts the same action commands below it.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24374
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ibf53f4797d7491b17a33946fd7d920f038362b4c
Gerrit-Change-Number: 24374
Gerrit-PatchSet: 12
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 01 Jun 2021 13:53:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210601/96fccb82/attachment.htm>


More information about the gerrit-log mailing list