Change in libosmocore[master]: ns2: Use NSVC bufid in stats report

pespin gerrit-no-reply at lists.osmocom.org
Tue Jun 1 13:32:17 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24468 )

Change subject: ns2: Use NSVC bufid in stats report
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> The "problem" with this approach is that it may look nice for IPA style NS-VC, but it will definitely look quite convoluted (and maybe even contain non-ctrl-capable characters?) for true 3GPP GbIP (e.g. IP-SNS) NSVC.  Those don't have an NSVCI so the only real identifier is the full tuple fo source/destination ip/port :(

If we find out we end up with some uncompatible character in there, it's as easy as adding a sanitize function, same we do with FSM names.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24468
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4c696c615ba3416f8524d0797ce06c0ecd3a18f2
Gerrit-Change-Number: 24468
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 01 Jun 2021 13:32:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210601/de7b5cc9/attachment.htm>


More information about the gerrit-log mailing list