Change in osmo-ggsn[master]: ggsn: Log tun fd write errors

pespin gerrit-no-reply at lists.osmocom.org
Tue Jun 1 11:22:57 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/24494 )

Change subject: ggsn: Log tun fd write errors
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ggsn/+/24494/1/lib/tun.h 
File lib/tun.h:

https://gerrit.osmocom.org/c/osmo-ggsn/+/24494/1/lib/tun.h@62 
PS1, Line 62: #define LOGTUN(level, tun, fmt, args...) \
> Why is it necessary to move the macro here?
because ggsn/ depends on lib/, not the other way. Since we start using the macro in code under lib/, we need it here.
Furthermore, it makes more sense to have it here, where all tun stuff is placed.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/24494
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I5f681b5edcc4cf525629d2078ae0c0ffd7ebb72d
Gerrit-Change-Number: 24494
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 01 Jun 2021 11:22:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210601/22605f3a/attachment.htm>


More information about the gerrit-log mailing list