Change in osmo-gsm-tester[master]: util: adds the feature to force the rpath when patching files.

pespin gerrit-no-reply at lists.osmocom.org
Tue Jun 1 10:51:24 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24272 )

Change subject: util: adds the feature to force the rpath when patching files.
......................................................................


Patch Set 1:

Ok so the summary IIUC is that you need --force-rpath because the toolchain/loader in the old kernel is not acting properly, as explained in "man patchelf":

"""
--force-rpath
Forces the use of the obsolete DT_RPATH in the file instead of DT_RUNPATH. By default DT_RPATH is converted to DT_RUNPATH
"""

Now, I'm still asking myself whether it's really needed to do this in OGT itself.
As far as I understand, you are building a special "inst" (trial) with binaries for that machine right? That means to me it makes much more sense to put these bits into the jobs building the "inst" archive. I see 2 possiblities:
1- Run the "patchelf --force-rpath --set-rpath /mnt/fns/bdlibs/" when generating the "inst", on each binary, since basically the path of where the libs are for the system your are building for is known at that time.
2- Move all the libs from /mnt/nfs/bdlibs to the "inst/lib" directory instead, so you have all non-system libraries needed there for that trial.

Can you give a try to option 1 and/or provide any feedback if you see any issue with the proposal?


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24272
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I2d4a105d4843c0d31d6b5d8f8d4195247b290aec
Gerrit-Change-Number: 24272
Gerrit-PatchSet: 1
Gerrit-Owner: alealcon <alejandro.leal at srs.io>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 01 Jun 2021 10:51:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210601/9145831e/attachment.htm>


More information about the gerrit-log mailing list