Change in osmo-ttcn3-hacks[master]: HACK: allow running parallel BTS_Tests.ConnHdlr components

fixeria gerrit-no-reply at lists.osmocom.org
Tue Jun 1 02:17:26 UTC 2021


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24479 )


Change subject: HACK: allow running parallel BTS_Tests.ConnHdlr components
......................................................................

HACK: allow running parallel BTS_Tests.ConnHdlr components

Unfortunately, trxcon does not support handling more than one
connection in parallel.  If there is already one connection
established, it would reject all other connection attempts.

This causes an error in f_handler_init().  As a quick hack,
let's allow running BTS_Tests.ConnHdlr components without
establishing L1CTL connections at all.

Change-Id: I72bcaed6c3803a0e18c9b787036a441e30c220cc
Related: SYS#4895, OS#4941
---
M bts/BTS_Tests.ttcn
1 file changed, 8 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/79/24479/1

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index d00c40e..8b10d0e 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -639,7 +639,8 @@
 /* create a new test component */
 friend function f_start_handler(void_fn fn, ConnHdlrPars pars,
 				boolean pcu_comp := false,
-				boolean trxc_comp := false)
+				boolean trxc_comp := false,
+				boolean l1ctl := true)
 runs on test_CT return ConnHdlr {
 	var charstring id := testcasename();
 	var ConnHdlr vc_conn;
@@ -660,6 +661,9 @@
 		unmap(self:BTS_TRXC, system:BTS_TRXC);
 		map(vc_conn:BTS_TRXC, system:BTS_TRXC);
 	}
+	if (l1ctl) {
+		map(vc_conn:L1CTL, system:L1CTL);
+	}
 
 	/* Obtain frequency hopping parameters for a given timeslot */
 	if (mp_freq_hop_enabled and mp_transceiver_num > 1) {
@@ -697,8 +701,9 @@
 	g_pars := pars;
 	g_chan_nr := pars.chan_nr;
 
-	map(self:L1CTL, system:L1CTL);
-	f_connect_reset(L1CTL);
+	if (L1CTL.checkstate("Mapped")) {
+		f_connect_reset(L1CTL);
+	}
 
 	if (mp_bts_trxc_port != -1 and BTS_TRXC.checkstate("Mapped")) {
 		f_init_trxc(BTS_TRXC, id, g_bts_trxc_conn_id);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24479
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I72bcaed6c3803a0e18c9b787036a441e30c220cc
Gerrit-Change-Number: 24479
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210601/5bc0a3da/attachment-0001.htm>


More information about the gerrit-log mailing list