Change in simtrace2[master]: firmware: make the ngff beakout blink ..but only if the cardem sim is...

osmith gerrit-no-reply at lists.osmocom.org
Fri Jul 30 14:36:41 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/25083 )

Change subject: firmware: make the ngff beakout blink ..but only if the cardem sim is active
......................................................................


Patch Set 8: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/simtrace2/+/25083/4//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/simtrace2/+/25083/4//COMMIT_MSG@8 
PS4, Line 8: 
> I'd mention that it blinks now when switching to remote/emulated SIM.
there should be a blank line after commit message subject



-- 
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/25083
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I65f1fbeb06690a143ef4c792728c9cb917a4ffde
Gerrit-Change-Number: 25083
Gerrit-PatchSet: 8
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Jul 2021 14:36:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210730/a829c0c6/attachment.htm>


More information about the gerrit-log mailing list