Change in osmo-pcu[master]: Move tbf ul_ack_state to osmocom FSM

osmith gerrit-no-reply at lists.osmocom.org
Fri Jul 30 14:02:57 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25108 )

Change subject: Move tbf ul_ack_state to osmocom FSM
......................................................................


Patch Set 4:

(3 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/25108/4/src/gprs_rlcmac_sched.cpp 
File src/gprs_rlcmac_sched.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/25108/4/src/gprs_rlcmac_sched.cpp@176 
PS4, Line 176: 				//msg = tbfs->ul_ack->create_ul_ack(fn, ts);
looks like it's not on purpose?


https://gerrit.osmocom.org/c/osmo-pcu/+/25108/4/src/tbf_ul.h 
File src/tbf_ul.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/25108/4/src/tbf_ul.h@a58 
PS4, Line 58: 	bool ctrl_ack_to_toggle();
can be deleted


https://gerrit.osmocom.org/c/osmo-pcu/+/25108/4/src/tbf_ul_ack_fsm.c 
File src/tbf_ul_ack_fsm.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/25108/4/src/tbf_ul_ack_fsm.c@253 
PS4, Line 253: 		/* FIXME: validate FN and TS match: && ctx->poll_fn = fn && ctx->poll_ts == ts */
* indentation
* is this out of scope for the patch?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25108
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Icf23bf5a4b85fbcbf1542cebceb76b9ba7185d30
Gerrit-Change-Number: 25108
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Jul 2021 14:02:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210730/5c6d5696/attachment.htm>


More information about the gerrit-log mailing list