Change in osmo-pcu[master]: tbf_dl: Clarify requirements for DL ACK/NACK

osmith gerrit-no-reply at lists.osmocom.org
Fri Jul 30 13:06:27 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25105 )

Change subject: tbf_dl: Clarify requirements for DL ACK/NACK
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

just some nitpicks

https://gerrit.osmocom.org/c/osmo-pcu/+/25105/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-pcu/+/25105/1//COMMIT_MSG@15 
PS1, Line 15: the code.
(seems like two logical changes at once... but given that the total patch size is still small I guess it's fine here)


https://gerrit.osmocom.org/c/osmo-pcu/+/25105/1/src/tbf_dl.cpp 
File src/tbf_dl.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/25105/1/src/tbf_dl.cpp@1214 
PS1, Line 1214: 	 * when last polled DL ACK/NACK was lost. */
(it would be nicer to describe the conditions in the same order as below.)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25105
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ib0e9b9547f5292b95064bab2dc182fdf659f0518
Gerrit-Change-Number: 25105
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Jul 2021 13:06:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210730/8d084509/attachment.htm>


More information about the gerrit-log mailing list