Change in osmo-pcu[master]: Move timer X2002 to tbf_fsm

osmith gerrit-no-reply at lists.osmocom.org
Fri Jul 30 12:55:04 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25104 )

Change subject: Move timer X2002 to tbf_fsm
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/25104/1/src/tbf_fsm.c 
File src/tbf_fsm.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/25104/1/src/tbf_fsm.c@212 
PS1, Line 212: 			LOGPTBF(ctx->tbf, LOGL_DEBUG, "Re-send dowlink assignment on PCH (IMSI=%s)\n",
dowlink -> downlink?

This typo was copied over from the other place. Maybe add a new commit that fixes it? it's three times in the code apparently.


https://gerrit.osmocom.org/c/osmo-pcu/+/25104/1/src/tbf_fsm.c@214 
PS1, Line 214: 			tbf_fsm_state_chg(fi, TBF_ST_ASSIGN);
just curious, why is this not at the bottom of the if block?

          tbf_fsm_state_chg(fi, TBF_ST_ASSIGN);
  }
  break;


https://gerrit.osmocom.org/c/osmo-pcu/+/25104/1/src/tbf_fsm.c@404 
PS1, Line 404: 			X(TBF_ST_RELEASING),
I think TBF_ST_ASSIGN needs to be added to out_state_mask



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25104
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I94b71c60ed49d51ebdf6d6b428056b4b94354676
Gerrit-Change-Number: 25104
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Jul 2021 12:55:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210730/c19c4d99/attachment.htm>


More information about the gerrit-log mailing list