Change in simtrace2[master]: Introduce simtrace2-tool

osmith gerrit-no-reply at lists.osmocom.org
Fri Jul 30 08:16:22 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/24574 )

Change subject: Introduce simtrace2-tool
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/simtrace2/+/24574/1/host/src/simtrace2-tool.c 
File host/src/simtrace2-tool.c:

https://gerrit.osmocom.org/c/simtrace2/+/24574/1/host/src/simtrace2-tool.c@293 
PS1, Line 293: 			rc = libusb_claim_interface(transp->usb_devh, if_num);
> why is this needed? I would expect "osmo_libusb_open_claim_interface" to claim it already
@Hoernchen: FYI I did not test this, just guessing by the name of the function. So I'm assuming you verified that it still works after removing this part.



-- 
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/24574
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I3a8896ac2b3caef7590b51118359e5caed820a40
Gerrit-Change-Number: 24574
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Jul 2021 08:16:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210730/90ddf5e3/attachment.htm>


More information about the gerrit-log mailing list