Change in osmo-ci[master]: lint: ignore LONG_LINE

osmith gerrit-no-reply at lists.osmocom.org
Fri Jul 30 08:11:57 UTC 2021


osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/25107 )

Change subject: lint: ignore LONG_LINE
......................................................................

lint: ignore LONG_LINE

With recent code reviews I've realized that in Osmocom we do often use
more than 120 characters per line for various reasons. So adjust the
linter to not fail anymore if that is the case.

Related: https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.h#32
Related: https://gerrit.osmocom.org/c/osmo-msc/+/25076/1/src/libmsc/msc_a.c#125
Related: OS#5087
Change-Id: I88fd86ac550fddb3017aeceb647c3d9e75367372
---
M lint/checkpatch/checkpatch_osmo.sh
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  osmith: Looks good to me, approved; Verified



diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh
index e88688a..abeed56 100755
--- a/lint/checkpatch/checkpatch_osmo.sh
+++ b/lint/checkpatch/checkpatch_osmo.sh
@@ -23,6 +23,7 @@
 # * INITIALISED_STATIC: we use this, see also http://lkml.iu.edu/hypermail/linux/kernel/0808.1/2235.html
 # * LINE_CONTINUATIONS: false positives
 # * LINE_SPACING: we don't always put a blank line after declarations
+# * LONG_LINE: should be 120 chars, but exceptions are done often so don't fail here
 # * PREFER_DEFINED_ATTRIBUTE_MACRO: macros like __packed not defined in libosmocore
 # * PREFER_FALLTHROUGH: pseudo keyword macro "fallthrough" is not defined in libosmocore
 # * REPEATED_WORD: false positives in doxygen descriptions (e.g. '\param[in] data Data passed through...')
@@ -50,6 +51,7 @@
 	--ignore INITIALISED_STATIC \
 	--ignore LINE_CONTINUATIONS \
 	--ignore LINE_SPACING \
+	--ignore LONG_LINE \
 	--ignore PREFER_DEFINED_ATTRIBUTE_MACRO \
 	--ignore PREFER_FALLTHROUGH \
 	--ignore REPEATED_WORD \

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/25107
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I88fd86ac550fddb3017aeceb647c3d9e75367372
Gerrit-Change-Number: 25107
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210730/8ea765dd/attachment.htm>


More information about the gerrit-log mailing list