Change in osmo-msc[master]: implement CM Re-Establish for voice calls
gerrit-no-reply at lists.osmocom.org
Thu Jul 29 17:00:09 UTC 2021
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/25076 )
Change subject: implement CM Re-Establish for voice calls
Patch Set 4: Code-Review+1
PS4, Line 921: * Clear any connections at will. */
I guess fixing this requires major refactoring and is out of scope for this patch. Hopefully there are plans to follow up?
PS1, Line 125: ? MSC_CTR_CM_RE_ESTABLISH_REQ_ACCEPTED : MSC_CTR_CM_RE_ESTABLISH_REQ_REJECTED));
> You can still merge it with linter CR-1
FWIW, the linter is still in testing, and therefore only enabled in osmo-mgw (a project I picked randomly). It seems that the line length check is more annoying than useful so I'll submit a patch to disable it. Ping me if it does something annoying, then I can fix it (or submit a patch to change the behavior yourself). The idea is that it errors on the cases where it's definitively against accepted coding standards, e.g.
but that it doesn't annoy us with false positives (such as the max line check that apparently is fine to ignore under certain conditions).
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/25076
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Jul 2021 17:00:09 +0000
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log