This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/25076 ) Change subject: implement CM Re-Establish for voice calls ...................................................................... Patch Set 4: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-msc/+/25076/4/src/libmsc/gsm_04_08.c File src/libmsc/gsm_04_08.c: https://gerrit.osmocom.org/c/osmo-msc/+/25076/4/src/libmsc/gsm_04_08.c@921 PS4, Line 921: * Clear any connections at will. */ I guess fixing this requires major refactoring and is out of scope for this patch. Hopefully there are plans to follow up? https://gerrit.osmocom.org/c/osmo-msc/+/25076/1/src/libmsc/msc_a.c File src/libmsc/msc_a.c: https://gerrit.osmocom.org/c/osmo-msc/+/25076/1/src/libmsc/msc_a.c@125 PS1, Line 125: ? MSC_CTR_CM_RE_ESTABLISH_REQ_ACCEPTED : MSC_CTR_CM_RE_ESTABLISH_REQ_REJECTED)); > You can still merge it with linter CR-1 +1 FWIW, the linter is still in testing, and therefore only enabled in osmo-mgw (a project I picked randomly). It seems that the line length check is more annoying than useful so I'll submit a patch to disable it. Ping me if it does something annoying, then I can fix it (or submit a patch to change the behavior yourself). The idea is that it errors on the cases where it's definitively against accepted coding standards, e.g. function() { instead of function() { but that it doesn't annoy us with false positives (such as the max line check that apparently is fine to ignore under certain conditions). -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/25076 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6fa37d6ca9fcb1637742b40e37b68d67664c9b60 Gerrit-Change-Number: 25076 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 29 Jul 2021 17:00:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210729/43dd4cf0/attachment.htm>