Change in osmo-msc[master]: implement CM Re-Establish for voice calls

osmith gerrit-no-reply at
Thu Jul 29 17:00:09 UTC 2021

osmith has posted comments on this change. ( )

Change subject: implement CM Re-Establish for voice calls

Patch Set 4: Code-Review+1

File src/libmsc/gsm_04_08.c: 
PS4, Line 921: 	 * Clear any connections at will. */
I guess fixing this requires major refactoring and is out of scope for this patch. Hopefully there are plans to follow up? 
File src/libmsc/msc_a.c: 
> You can still merge it with linter CR-1


FWIW, the linter is still in testing, and therefore only enabled in osmo-mgw (a project I picked randomly). It seems that the line length check is more annoying than useful so I'll submit a patch to disable it. Ping me if it does something annoying, then I can fix it (or submit a patch to change the behavior yourself). The idea is that it errors on the cases where it's definitively against accepted coding standards, e.g.

  function() {

instead of


but that it doesn't annoy us with false positives (such as the max line check that apparently is fine to ignore under certain conditions).

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I6fa37d6ca9fcb1637742b40e37b68d67664c9b60
Gerrit-Change-Number: 25076
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at>
Gerrit-CC: pespin <pespin at>
Gerrit-Comment-Date: Thu, 29 Jul 2021 17:00:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr at>
Comment-In-Reply-To: pespin <pespin at>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list