Change in osmo-mgw[master]: mgcp_ratectr: add stats items to monitor trunk usage

pespin gerrit-no-reply at lists.osmocom.org
Thu Jul 29 15:52:36 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25041 )

Change subject: mgcp_ratectr: add stats items to monitor trunk usage
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/25041/2/src/libosmo-mgcp/mgcp_ratectr.c 
File src/libosmo-mgcp/mgcp_ratectr.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/25041/2/src/libosmo-mgcp/mgcp_ratectr.c@271 
PS2, Line 271: static int free_stat_item_group(struct osmo_stat_item_group *stat_item_group)
I usually add "talloc_destructor" at the end of this function name, to clearly state it's for talloc internall calling and should not be called directly.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25041
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I6d3a74f6087512130d85002348787bffc672de81
Gerrit-Change-Number: 25041
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Jul 2021 15:52:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210729/34b33f68/attachment.htm>


More information about the gerrit-log mailing list