Change in osmo-pcu[master]: Replace ul_ass_state with osmocom FSM

pespin gerrit-no-reply at lists.osmocom.org
Thu Jul 29 11:45:16 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25056 )

Change subject: Replace ul_ass_state with osmocom FSM
......................................................................


Patch Set 4:

(5 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf.cpp 
File src/tbf.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf.cpp@a767 
PS4, Line 767: s X2000,
> why was this removed? (maybe it makes sense to do this in a separate commit and explain it there?)
Timer X2000 is moved inside the new FSM, so it's not handled by this pcu-specific mechansim anymore, but using usual osmocom FSM timer callback.


https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf.cpp@967 
PS4, Line 967: 	osmo_fsm_inst_update_id(tbf->ul_ass_fsm.fi, buf);
> Why give two separate FSMs the same ID, wouldn't it be better to add some kind of suffix that differ […]
No need for that, the name of the FSM (which is different for the 2 types) always show up next to the id, so it's totally fine. Having same ID actually helps in quickly relating different FSMs to same TBF.


https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.h 
File src/tbf_ul_ass_fsm.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.h@32 
PS4, Line 32: 	TBF_UL_ASS_EV_CREATE_RLCMAC_MSG, /* Scheduler wants to gen+Tx the Ass (rej): data=tbf_ul_ass_ev_create_rlcmac_msg_ctx */
> (line length)
I prefer keeping comment in one line even if it's a few chars too long.


https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.h@52 
PS4, Line 52: fi
> (Same for "replace dl_ass_state with osmocom FSM" patch)
no, the comment is fine. "the_pcu" is actually a global variable which always exists :)


https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.c 
File src/tbf_ul_ass_fsm.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.c@306 
PS4, Line 306: bool tbf_ul_ass_rts(const struct gprs_rlcmac_tbf* tbf)
> assuming rts means.... ready to send? would be good to add it as comment […]
It's common in different osmocom projects like osmo-bts. I'm already using same sort of naming for other FSMs such as the NACC one. These functions are basically used from the scheduler to know whether a related message is waiting to be preparted and sent.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25056
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Id414eafe9c04a9a8759c6fb1a483bf2ee093a4d2
Gerrit-Change-Number: 25056
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Jul 2021 11:45:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210729/93c071c8/attachment.htm>


More information about the gerrit-log mailing list