Change in osmo-msc[master]: implement CM Re-Establish for voice calls

neels gerrit-no-reply at lists.osmocom.org
Wed Jul 28 16:45:59 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/25076 )

Change subject: implement CM Re-Establish for voice calls
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/osmo-msc/+/25076/1/src/libmsc/msc_a.c 
File src/libmsc/msc_a.c:

https://gerrit.osmocom.org/c/osmo-msc/+/25076/1/src/libmsc/msc_a.c@125 
PS1, Line 125: 						    ? MSC_CTR_CM_RE_ESTABLISH_REQ_ACCEPTED : MSC_CTR_CM_RE_ESTABLISH_REQ_REJECTED));
> Not blocking, but I'd keep it in one line like the other ones above. […]
I fear the linter will give me CR -1



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/25076
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I6fa37d6ca9fcb1637742b40e37b68d67664c9b60
Gerrit-Change-Number: 25076
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 28 Jul 2021 16:45:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210728/1d4c0df0/attachment.htm>


More information about the gerrit-log mailing list