Change in osmo-bsc[master]: doc: Improve ACC ramp documentation

osmith gerrit-no-reply at lists.osmocom.org
Wed Jul 28 16:40:47 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25087 )

Change subject: doc: Improve ACC ramp documentation
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/25087/2/doc/manuals/chapters/bts.adoc 
File doc/manuals/chapters/bts.adoc:

https://gerrit.osmocom.org/c/osmo-bsc/+/25087/2/doc/manuals/chapters/bts.adoc@482 
PS2, Line 482: `access-control-class-ramping-chan-load` VTY command.
* "will actually be checked always" sounds a bit strange to me, how about "will always be checked"
* "the" missing before "start up procedure", before `access-control-class-ramping-step-interval` and before `access-control-class-ramping-chan-load`
* This sentence is very long and therefore hard to read. How about:

... VTY command. It will either keep, ...

instead of

 ... VTY command, and will either keep, ...


https://gerrit.osmocom.org/c/osmo-bsc/+/25087/2/doc/manuals/chapters/bts.adoc@526 
PS2, Line 526: <6> The time until the subset size is further increased or decreased based on current channel load check (in seconds)
In the other lines, the exact config value is mentioned instead of a generic description.

So here I would put the 30s, e.g.

  <6> 30 seconds until the subset size is further increased or decreased based on the current channel load check



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25087
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I8701386b35ccdebfc843fd00535091648e52f739
Gerrit-Change-Number: 25087
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Wed, 28 Jul 2021 16:40:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210728/9f175fa3/attachment.htm>


More information about the gerrit-log mailing list