This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/25076 ) Change subject: implement CM Re-Establish for voice calls ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/osmo-msc/+/25076/1/include/osmocom/msc/gsm_data.h File include/osmocom/msc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-msc/+/25076/1/include/osmocom/msc/gsm_data.h@47 PS1, Line 47: MSC_CTR_CM_RE_ESTABLISH_REQ_ACCEPTED, Swap these 2. In all the other endums above, REJECTED comes prior to ACCEPTED, as well as in rate_ctr_desc below (you ar ehence swapping the order below). https://gerrit.osmocom.org/c/osmo-msc/+/25076/1/src/libmsc/gsm_04_08.c File src/libmsc/gsm_04_08.c: https://gerrit.osmocom.org/c/osmo-msc/+/25076/1/src/libmsc/gsm_04_08.c@928 PS1, Line 928: vlr_proc_acc_req(msc_a->c.fi, looks like we may want to create a new req struct to pass to this function at some point ;) https://gerrit.osmocom.org/c/osmo-msc/+/25076/1/src/libmsc/msc_a.c File src/libmsc/msc_a.c: https://gerrit.osmocom.org/c/osmo-msc/+/25076/1/src/libmsc/msc_a.c@125 PS1, Line 125: ? MSC_CTR_CM_RE_ESTABLISH_REQ_ACCEPTED : MSC_CTR_CM_RE_ESTABLISH_REQ_REJECTED)); Not blocking, but I'd keep it in one line like the other ones above. Furthermore I find having the "?" in a new line really strange, and looking at previous line it looks like simply "conn_accepted" is being passed. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/25076 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6fa37d6ca9fcb1637742b40e37b68d67664c9b60 Gerrit-Change-Number: 25076 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 28 Jul 2021 12:21:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210728/5fbdc7c1/attachment.htm>