Change in libosmo-sccp[master]: m3ua: reject deregistration of static routing keys

[osmith]

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/25024 )

Change subject: m3ua: reject deregistration of static routing keys
......................................................................

m3ua: reject deregistration of static routing keys

Make STP_Tests_M3UA.TC_rkm_unreg_never_registered pass.

Closes: OS#4239
Change-Id: Ie5d84d06e7d5d32c8a22f770f71a5449f4a78484
---
M src/xua_rkm.c
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  dexter: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved



diff --git a/src/xua_rkm.c b/src/xua_rkm.c
index 10335ea..6abd17d 100644
--- a/src/xua_rkm.c
+++ b/src/xua_rkm.c
@@ -350,6 +350,12 @@
 		return -1;
 	}
 
+	/* Reject if not dynamically allocated (OS#4239) */
+	if (!as->rkm_dyn_allocated) {
+		msgb_append_dereg_res(resp, M3UA_RKM_DEREG_ERR_NOT_REGD, 0);
+		return -1;
+	}
+
 	/* Reject if ASP is not even part of AS */
 	if (!osmo_ss7_as_has_asp(as, asp)) {
 		msgb_append_dereg_res(resp, M3UA_RKM_DEREG_ERR_INVAL_RCTX, 0);

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/25024
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ie5d84d06e7d5d32c8a22f770f71a5449f4a78484
Gerrit-Change-Number: 25024
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210727/53eedbd1/attachment.htm>