Change in osmo-pcu[master]: Get rid of tbf_dl:abort()

pespin gerrit-no-reply at lists.osmocom.org
Tue Jul 27 10:50:54 UTC 2021


Hello osmith, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-pcu/+/25054

to look at the new patch set (#2).

Change subject: Get rid of tbf_dl:abort()
......................................................................

Get rid of tbf_dl:abort()

Having that code in a separate function is confusing and adds code
complexity since it looks like an entry point to start feeing a TBF, but
it simply some (not yet really useful) set of instructions to be called
one 1 code path in tbf_free.
Let's move it there, this way it becomes clear tbf_free() is THE place
to be (if you want to get rid of a TBF).

Change-Id: I30febf4d21a0bfab37524c07598bbb0dd32f7f65
---
M src/tbf.cpp
M src/tbf_dl.cpp
M src/tbf_dl.h
3 files changed, 15 insertions(+), 29 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/54/25054/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25054
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I30febf4d21a0bfab37524c07598bbb0dd32f7f65
Gerrit-Change-Number: 25054
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210727/c4d64ee5/attachment.htm>


More information about the gerrit-log mailing list