Change in osmo-pcu[master]: Move RELEASING tbf_state transition to tbf_fsm

pespin gerrit-no-reply at lists.osmocom.org
Tue Jul 27 10:43:28 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25047 )

Change subject: Move RELEASING tbf_state transition to tbf_fsm
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/25047/1/src/tbf_fsm.c 
File src/tbf_fsm.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/25047/1/src/tbf_fsm.c@194 
PS1, Line 194: 	//struct tbf_fsm_ctx *ctx = (struct tbf_fsm_ctx *)fi->priv;
> added on purpose?
TBH I usually add them on purpose as a skeleton in order to speed up implementation since usually one ends up using it, maybe not in this commit but in a follow up one when I extend the FSMs (because I'm splitting the whole FSM implementation in order to make it testeable, check regressions, and ease code review).



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25047
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I516b8d989a0d705e5664f8aeaf7d108e0105aa16
Gerrit-Change-Number: 25047
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 27 Jul 2021 10:43:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210727/5fb24f80/attachment.htm>


More information about the gerrit-log mailing list