This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25011 ) Change subject: Move NULL and ASSIGN tbf_state transition to tbf_fsm ...................................................................... Patch Set 4: (5 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/25011/4/src/pdch.cpp File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/25011/4/src/pdch.cpp@371 PS4, Line 371: if (new_tbf->state_fsm.state_flags & (1 << GPRS_RLCMAC_FLAG_CCCH)) { I'm wondering, what's the rationale behind replacing check_n_clear here, but still using it in other places? I would have expected that you removed it completely when I saw this. https://gerrit.osmocom.org/c/osmo-pcu/+/25011/4/src/tbf.cpp File src/tbf.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/25011/4/src/tbf.cpp@581 PS4, Line 581: if ((state_fsm.state_flags & (1 << (GPRS_RLCMAC_FLAG_PACCH))) && (state_fsm.state_flags & (1 << (GPRS_RLCMAC_FLAG_CCCH)))) (line length) https://gerrit.osmocom.org/c/osmo-pcu/+/25011/4/src/tbf_fsm.h File src/tbf_fsm.h: https://gerrit.osmocom.org/c/osmo-pcu/+/25011/4/src/tbf_fsm.h@33 PS4, Line 33: //TBF_EV_ASSIGN_DEL_PACCH, commented out? https://gerrit.osmocom.org/c/osmo-pcu/+/25011/4/src/tbf_fsm.h@48 PS4, Line 48: uint32_t state_flags; Have you considered calling it "flags", so it's "state_fsm.flags" instead of "state_fsm.state_flags" everywhere? https://gerrit.osmocom.org/c/osmo-pcu/+/25011/4/src/tbf_fsm.c File src/tbf_fsm.c: https://gerrit.osmocom.org/c/osmo-pcu/+/25011/4/src/tbf_fsm.c@47 PS4, Line 47: //{ TBF_EV_ASSIGN_DEL_PACCH, "ASSIGN_DEL_PACCH" }, commented out? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25011 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3c62e9e83965cb28065338733f182863e54d7474 Gerrit-Change-Number: 25011 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jul 2021 09:29:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210727/0c8211ec/attachment.htm>