Change in docker-playground[master]: debian-stretch-titan: Wait for interface to be _up_ not just its exis...

osmith gerrit-no-reply at lists.osmocom.org
Tue Jul 27 09:00:37 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/22674 )

Change subject: debian-stretch-titan: Wait for interface to be _up_ not just its existance
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/docker-playground/+/22674/3/debian-stretch-titan/ttcn3-docker-run.sh 
File debian-stretch-titan/ttcn3-docker-run.sh:

https://gerrit.osmocom.org/c/docker-playground/+/22674/3/debian-stretch-titan/ttcn3-docker-run.sh@24 
PS3, Line 24: 		OPSTATE=`cat /sys/class/net/${WAIT_FOR_NETDEV}/operstate`
Use $(...) notation instead of legacy backticked `...`.

https://github.com/koalaman/shellcheck/wiki/Sc2006



-- 
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/22674
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I1bfb6eb925bca4e4e1901e06eed831152cddbbe2
Gerrit-Change-Number: 22674
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Assignee: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 27 Jul 2021 09:00:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210727/72d6086a/attachment.htm>


More information about the gerrit-log mailing list