Change in osmo-pcu[master]: tests/tbf: Fix null pointer access if slowly stepping with gdb

daniel gerrit-no-reply at lists.osmocom.org
Mon Jul 26 14:27:32 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25044 )

Change subject: tests/tbf: Fix null pointer access if slowly stepping with gdb
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/25044/1/tests/tbf/TbfTest.cpp 
File tests/tbf/TbfTest.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/25044/1/tests/tbf/TbfTest.cpp@69 
PS1, Line 69: 	bssgp_set_bssgp_callback(gprs_gp_send_test_cb, pcu->nsi);
> pcu->nsi will always be NULL here so you might as well just pass NULL
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25044
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Iee5bcf21afc8980a14f90f5b1ead6d2460a244ea
Gerrit-Change-Number: 25044
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Jul 2021 14:27:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210726/a29ddedb/attachment.htm>


More information about the gerrit-log mailing list