Change in osmo-mgw[master]: mgcp_ratectr: add stats items to monitor trunk usage

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Jul 26 12:57:58 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25041 )

Change subject: mgcp_ratectr: add stats items to monitor trunk usage
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/c/osmo-mgw/+/25041/1/src/libosmo-mgcp/mgcp_endp.c 
File src/libosmo-mgcp/mgcp_endp.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/25041/1/src/libosmo-mgcp/mgcp_endp.c@126 
PS1, Line 126: 	/* We must only decrement the stat item when the endpoint as actually
"is actually" or "has actually been"


https://gerrit.osmocom.org/c/osmo-mgw/+/25041/1/src/libosmo-mgcp/mgcp_ratectr.c 
File src/libosmo-mgcp/mgcp_ratectr.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/25041/1/src/libosmo-mgcp/mgcp_ratectr.c@293 
PS1, Line 293: 	talloc_set_destructor(stats->common, free_stat_item_group);
I don't think this is a good idea (changing/setting a talloc destructor for a lib-controlled struct allocated with its own API).

Instead, set the talloc destructor on the trunk object when creating it, and free the item_groups there.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25041
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I6d3a74f6087512130d85002348787bffc672de81
Gerrit-Change-Number: 25041
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Jul 2021 12:57:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210726/69f9ebbf/attachment.htm>


More information about the gerrit-log mailing list