Change in osmo-mgw[master]: mgcp_ratectr: add stats items to monitor trunk usage

daniel gerrit-no-reply at lists.osmocom.org
Fri Jul 23 13:04:25 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24942 )

Change subject: mgcp_ratectr: add stats items to monitor trunk usage
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/24942/7/src/libosmo-mgcp/mgcp_ratectr.c 
File src/libosmo-mgcp/mgcp_ratectr.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/24942/7/src/libosmo-mgcp/mgcp_ratectr.c@276 
PS7, Line 276: int mgcp_stat_trunk_alloc(struct mgcp_trunk *trunk)
You need to add
talloc_set_destructor(stats->common, free_stat_item_group);
and free the stat_item group in there.

It's weird that the jenkins job didn't catch that. Do we not use ASAN for these?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24942
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ib7b654168dc3512f55e45cc4755dc1f6f423d023
Gerrit-Change-Number: 24942
Gerrit-PatchSet: 7
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Jul 2021 13:04:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210723/915da05f/attachment.htm>


More information about the gerrit-log mailing list