Change in osmo-pcu[master]: tbf: Drop impossible paths in create_dl_ass()

pespin gerrit-no-reply at lists.osmocom.org
Fri Jul 23 12:42:18 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25010 )

Change subject: tbf: Drop impossible paths in create_dl_ass()
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review+1
> 
> I guess it makes sense to keep poll_ass_dl as variable even if it's only used when encoding the packet.

Yes, it's easier to understand what is being passed to the encoding function imho.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25010
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ibea4100a5dc8bd49303cb6a3d02417038c3d3887
Gerrit-Change-Number: 25010
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Jul 2021 12:42:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210723/13d29194/attachment.htm>


More information about the gerrit-log mailing list