This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25004 ) Change subject: mcgp_client: initalize domain name from mgcp_client_conf_init ...................................................................... Patch Set 1: > Patch Set 1: Code-Review-1 > > Are you sure about this? I'd expect it to be initialized the zero when the assignment is done immediately beforehand. Did you experience an issue with it? > In any case, probably setting name[0] = '\0'; would be enough I guess. Its because the struct member is not set in the assignment, so its filled up with zeros, is it that what you mean? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25004 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iabef17c7ab0e0f4a9a0cb3ad4ec83006bd07f566 Gerrit-Change-Number: 25004 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 22 Jul 2021 13:17:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210722/719e372a/attachment.htm>