Change in osmo-bsc[master]: RES IND: tweak error code on missing Resource Information IE

neels gerrit-no-reply at lists.osmocom.org
Thu Jul 22 12:15:37 UTC 2021


neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25003 )

Change subject: RES IND: tweak error code on missing Resource Information IE
......................................................................

RES IND: tweak error code on missing Resource Information IE

If the RES IND message is invalid, let's not return ENOENT which
translates to "No such file or directory", instead return EINVAL.

Related: SYS#5313
Change-Id: Ifd700e90c881874d428f2860603a4ddbf13d705e
---
M src/osmo-bsc/abis_rsl.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index 02037e1..8e4916d 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -1495,7 +1495,7 @@
 	res_info_ie = TLVP_GET(&tp, RSL_IE_RESOURCE_INFO);
 	if (!res_info_ie) {
 		LOGP(DRSL, LOGL_ERROR, "Rx Resource Indication: missing Resource Info IE\n");
-		return -ENOENT;
+		return -EINVAL;
 	}
 
 	/* The IE value is defined in 3GPP TS 48.058 9.3.21 Resource Information:

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25003
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ifd700e90c881874d428f2860603a4ddbf13d705e
Gerrit-Change-Number: 25003
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210722/bcea93ce/attachment.htm>


More information about the gerrit-log mailing list