Change in osmo-bsc[master]: Fix recent regression in CHREQ allocation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Jul 22 12:08:39 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25005 )

Change subject: Fix recent regression in CHREQ allocation
......................................................................

Fix recent regression in CHREQ allocation

Recent commit introduces a silly bug when changing code. Fixing it now.

Fixes: fdb87343d7a747575fae0bb436cd9d105b9748e9
Change-Id: I1e8027a3933c3c8450e76e1325d0f7c28a89a6d1
---
M src/osmo-bsc/abis_rsl.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  neels: Looks good to me, approved



diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index 5bb0efe..f6ae19a 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -2004,7 +2004,7 @@
 	 *
 	 */
 
-	if (GSM_CHREQ_REASON_CALL) {
+	if (rqd->reason == GSM_CHREQ_REASON_CALL) {
 		 lchan = _select_sdcch_for_call(bts, rqd, lctype);
 	} else if (rqd->reason != GSM_CHREQ_REASON_EMERG) {
 		lchan = lchan_select_by_type(bts, GSM_LCHAN_SDCCH);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25005
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1e8027a3933c3c8450e76e1325d0f7c28a89a6d1
Gerrit-Change-Number: 25005
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210722/9b7aab4e/attachment.htm>


More information about the gerrit-log mailing list