Change in osmo-mgw[master]: mgcp_protocol: add support for wildcarded DLCX

dexter gerrit-no-reply at lists.osmocom.org
Wed Jul 21 09:10:59 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24973 )

Change subject: mgcp_protocol: add support for wildcarded DLCX
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-mgw/+/24973/1/src/libosmo-mgcp/mgcp_protocol.c 
File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/24973/1/src/libosmo-mgcp/mgcp_protocol.c@1365 
PS1, Line 1365: 	 * pointer will be populated, however it is guaranteed that only. */
> guaranteed that only? what?
Done


https://gerrit.osmocom.org/c/osmo-mgw/+/24973/1/src/libosmo-mgcp/mgcp_protocol.c@1376 
PS1, Line 1376: 	if (endp && !rq->wildcarded && llist_empty(&endp->conns)) {
> can we still have endp and be wildcarded¿
yes. If the trunk resources are not exhausted we will always get an endpoint.

(I am asking myself it it would be simpler to have an handle_delete_con_wc, basically we would do have two handlers then, one for the normal DLCX and one for the wildcarded. What also makes this patch complicated is the policy_cb. I must get past this code section to execute what I want to do and until there everything must be endp==NULL safe.)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24973
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I5c2de6b2b61ee64ba9c0618fd20e8fc2fe6a5ed3
Gerrit-Change-Number: 24973
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Jul 2021 09:10:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210721/57c90d60/attachment.htm>


More information about the gerrit-log mailing list