Change in osmo-mgw[master]: mgcp_protocol: add support for wildcarded DLCX

pespin gerrit-no-reply at lists.osmocom.org
Tue Jul 20 15:39:55 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24973 )

Change subject: mgcp_protocol: add support for wildcarded DLCX
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-mgw/+/24973/1/src/libosmo-mgcp/mgcp_protocol.c 
File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/24973/1/src/libosmo-mgcp/mgcp_protocol.c@1365 
PS1, Line 1365: 	 * pointer will be populated, however it is guaranteed that only. */
guaranteed that only? what?


https://gerrit.osmocom.org/c/osmo-mgw/+/24973/1/src/libosmo-mgcp/mgcp_protocol.c@1376 
PS1, Line 1376: 	if (endp && !rq->wildcarded && llist_empty(&endp->conns)) {
can we still have endp and be wildcarded¿



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24973
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I5c2de6b2b61ee64ba9c0618fd20e8fc2fe6a5ed3
Gerrit-Change-Number: 24973
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Jul 2021 15:39:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210720/2a67dccd/attachment.htm>


More information about the gerrit-log mailing list