Change in osmo-mgw[master]: mgcp_protocol: refactor MGCP request handling

dexter gerrit-no-reply at lists.osmocom.org
Mon Jul 19 13:05:08 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24941 )

Change subject: mgcp_protocol: refactor MGCP request handling
......................................................................


Patch Set 5:

(1 comment)

> Patch Set 5: Code-Review+1
> 
> You changed the log line to avoid saying "fail" in the log line, but my wonder was more in the direction of why are we logging a NOTICE level log line for a scenario which is expected when a wildcarded DLCX is received.

I have put the log level to notice because the line appears only when the all trunk resources are in use, which is already a problem but until that point we can not say if we are able to execute the request handler properly. Wildcarded DLCX is at the moment the only situation that would turn out well.

Normally a wildcarded request will always get an endpoint, it will be always the next endpoint that is free. When all trunk resources are in use, we will get a trunk only.

https://gerrit.osmocom.org/c/osmo-mgw/+/24941/4/src/libosmo-mgcp/mgcp_protocol.c 
File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/24941/4/src/libosmo-mgcp/mgcp_protocol.c@374 
PS4, Line 374: 		LOGP(DLMGCP, LOGL_NOTICE,
> I still don't get why printing a failure here, if it's actually accepted to receive no endpoint, for […]
Maybe "cannot find endpoint" sounds better here.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24941
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I9f519d8a0ee8a513fa1e74acf3ee7dbc0991cdde
Gerrit-Change-Number: 24941
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Jul 2021 13:05:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210719/c5012975/attachment.htm>


More information about the gerrit-log mailing list