Change in osmo-bts[master]: allow to configure multiple oml remote-ip addresses

dexter gerrit-no-reply at lists.osmocom.org
Mon Jul 19 09:14:52 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24513 )

Change subject: allow to configure multiple oml remote-ip addresses
......................................................................


Patch Set 11:

(1 comment)

> Patch Set 11:
> 
> This patch is not yet ready. If you do VTY cmd "no oml remote-ip 1.2.3.4" while abis link is connected, the program will abort hitting the assert I mentioned in my previous comment.

(sorry I confused that in the ticket updates)

I checked this again. See my commet. I don't believe that that the assert can be ever be hit.

https://gerrit.osmocom.org/c/osmo-bts/+/24513/10/src/common/abis.c 
File src/common/abis.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24513/10/src/common/abis.c@92 
PS10, Line 92: 
> AFAIU you can also receive the other new event here now, which would make this assert?
I have checked this twice now, I am very sure that this action is not executed when the other new event is received since it is received in the allstate action which is is executed before the normal action. Also the other event is not permitted in this state.

See also:
http://git.osmocom.org/libosmocore/tree/src/fsm.c#n864



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24513
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I205f68a3a7f35fee4c38a7cfba2b014237df2727
Gerrit-Change-Number: 24513
Gerrit-PatchSet: 11
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Jul 2021 09:14:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210719/7aa79788/attachment.htm>


More information about the gerrit-log mailing list