Change in osmo-ci[master]: lint: ignore DEEP_INDENTATION

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Jul 16 16:01:15 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/24920 )

Change subject: lint: ignore DEEP_INDENTATION
......................................................................

lint: ignore DEEP_INDENTATION

Related: OS#5087
Change-Id: Iff29f0a97dbfed904705f543541441f761370602
---
M lint/checkpatch/checkpatch_osmo.sh
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  laforge: Looks good to me, but someone else must approve; Verified



diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh
index 7ee8ed6..4be1348 100755
--- a/lint/checkpatch/checkpatch_osmo.sh
+++ b/lint/checkpatch/checkpatch_osmo.sh
@@ -11,6 +11,7 @@
 # * BLOCK_COMMENT_STYLE: we don't use a trailing */ on a separate line
 # * COMPLEX_MACRO: we don't use parentheses when building macros of strings across multiple lines
 # * CONSTANT_COMPARISON: not followed: "Comparisons should place the constant on the right side"
+# * DEEP_INDENTATION: warns about many leading tabs, not useful if changing existing code without refactoring
 # * EMBEDDED_FUNCTION_NAME: often __func__ isn't used, arguably not much benefit in changing this when touching code
 # * EXECUTE_PERMISSIONS: not followed, files need to be executable: git-version-gen, some in debian/
 # * FILE_PATH_CHANGES: we don't use a MAINTAINERS file
@@ -34,6 +35,7 @@
 	--ignore BLOCK_COMMENT_STYLE \
 	--ignore COMPLEX_MACRO \
 	--ignore CONSTANT_COMPARISON \
+	--ignore DEEP_INDENTATION \
 	--ignore EMBEDDED_FUNCTION_NAME \
 	--ignore EXECUTE_PERMISSIONS \
 	--ignore FILE_PATH_CHANGES \

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/24920
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Iff29f0a97dbfed904705f543541441f761370602
Gerrit-Change-Number: 24920
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210716/4bbdc954/attachment.htm>


More information about the gerrit-log mailing list