Change in osmo-mgw[master]: mgcp_protocol: refactor MGCP request handling

pespin gerrit-no-reply at lists.osmocom.org
Fri Jul 16 15:54:28 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24941 )

Change subject: mgcp_protocol: refactor MGCP request handling
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/24941/4/src/libosmo-mgcp/mgcp_protocol.c 
File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/24941/4/src/libosmo-mgcp/mgcp_protocol.c@374 
PS4, Line 374: 		LOGP(DLMGCP, LOGL_NOTICE,
I still don't get why printing a failure here, if it's actually accepted to receive no endpoint, for instance in wildcarded DLC (that's why you are doing this refactor right?)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24941
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I9f519d8a0ee8a513fa1e74acf3ee7dbc0991cdde
Gerrit-Change-Number: 24941
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Jul 2021 15:54:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210716/714fca90/attachment.htm>


More information about the gerrit-log mailing list